ref: Support Unity as a platfom
#4322
Merged
+43
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitsandfoxes
changed the title
SentrySdk
bitsandfoxes
changed the title
SentrySdkUnity as a platfom
bitsandfoxes
commented
Jul 7, 2025
Comment on lines
+5
to
+18
| /// <summary> | ||
| /// Internal Sentry SDK entrypoint. | ||
| /// </summary> | ||
| /// <remarks> | ||
| /// This class is now internal. Use <c>Sentry.Unity.SentrySdk</c> instead. | ||
| /// <para> | ||
| /// To migrate your code: | ||
| /// <list type="number"> | ||
| /// <item>Change <c>using Sentry;</c> to <c>using Sentry.Unity;</c></item> | ||
| /// <item>Keep using the <c>SentrySdk</c> API itself - no changes needed to method calls</item> | ||
| /// <item>Add <c>using Sentry;</c> if you need access to types like <c>SentryId</c>, <c>SentryLevel</c>, etc.</item> | ||
| /// </list> | ||
| /// </para> | ||
| /// </remarks> |
There was a problem hiding this comment.
This is only visible to Unity SDK users. The changes here are part of breaking changes to the Unity SDK and this aims to reduce friction when migrating.
bitsandfoxes
commented
Jul 7, 2025
| @@ -7,29 +7,19 @@ | |||
| <AllowUnsafeBlocks>true</AllowUnsafeBlocks> | |||
| </PropertyGroup> | |||
|
|
|||
| <PropertyGroup Condition="'$(SolutionName)' != 'Sentry.Unity'"> | |||
| <PropertyGroup> | |||
There was a problem hiding this comment.
We no longer need to conditionally set the TF, they get overwritten by the platform .props on line 4.
bruno-garcia
approved these changes
Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comes from getsentry/sentry-unity#2227
The goal is to provide the Unity SDK a way to "internalize" the .NET SDK. This works because the Unity SDK builds the .NET SDK from source. The relevant changes happen in
SentrySdk.cs.We noticed the similarity between
Unityand the platformsAndroid,iOS, andNative. All the Unity specific junk from theSentry.csprojnow goes into its own.props.To lend the argument "Unity is its own platform" some credibility we dug out some ms docs.
#skip-changelog